]> dgit.raspbian.org Git - gnome-shell.git/commit
texture-cache: Use image-missing image when no other icon was loaded
authorMario Sanchez Prada <mario@endlessm.com>
Wed, 10 May 2017 14:59:32 +0000 (15:59 +0100)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Mon, 23 Mar 2020 16:50:06 +0000 (13:50 -0300)
commit3dd8ffc2bb1cefd603bcadabd8886dda3192dbd5
tree456dfe33e740bd8b02049276cf856d3fc975b396
parent541847d8b60238abe2468c7c99013f87a69122c3
texture-cache: Use image-missing image when no other icon was loaded

If a given icon is not available for neither the current theme nor any
of the fallback options (default theme -"Adwaita", "gnome"...), the
call to gtk_icon_theme_lookup_by_gicon() will return a NULL value, which
returned by the Shell Toolkit as is, causing trouble in the Shell's JS
code when calling shell_app_create_icon_texture() to create an icon.

To at least mitigate the chances of this having this issue happening, we
should at least try to load the standad 'image-missing' icon from the
Icon Naming Specification spec when we receive a NULL here, so that
at least we try to show something to the user, even if it's ugly.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1121
src/st/st-texture-cache.c